CutCodeDown

Squire / Paladin => Squire/Paladin General Discussion => Topic started by: Jason Knight on 1 Dec 2020, 06:31:23 am

Title: directory layout changes
Post by: Jason Knight on 1 Dec 2020, 06:31:23 am
I've moved css into it's own /template/templatename/css, but should I move the .template.php files into their own "php" subdirectory as well? Would that be an improvement, or would it make things confusing?

Side note, the admin panel for user creation/deletion/listing is about halfway there.
Title: Re: directory layout changes
Post by: GrumpyYoungMan on 1 Dec 2020, 06:41:40 am
I've moved css into it's own /template/templatename/css, but should I move the .template.php files into their own "php" subdirectory as well? Would that be an improvement, or would it make things confusing?

I like that idea as it would making skinning it easier to?

Side note, the admin panel for user creation/deletion/listing is about halfway there.

:)
Title: Re: directory layout changes
Post by: xmohamadx on 1 Dec 2020, 07:08:45 am
I've moved css into it's own /template/templatename/css, but should I move the .template.php files into their own "php" subdirectory as well? Would that be an improvement, or would it make things confusing

not a big deal but seems more organized, maybe someday php template files grow!
but surely not confusing
Title: Re: directory layout changes
Post by: benanamen on 1 Dec 2020, 12:02:21 pm
I expect ALL css to be in a single folder. I expect ALL Js to be in a single folder. I expect a templates folder to ONLY have templates and either be in the the public dir or above it. Anything else is a "surprise".
Title: Re: directory layout changes
Post by: GrumpyYoungMan on 1 Dec 2020, 12:16:26 pm
I expect ALL css to be in a single folder. I expect ALL Js to be in a single folder. I expect a templates folder to ONLY have templates and either be in the the public dir or above it. Anything else is a "surprise".
Or a “skin”(s) directory for various skin/CSS files?
Title: Re: directory layout changes
Post by: benanamen on 1 Dec 2020, 12:25:15 pm
Yes. Point being logically grouped together.
Title: Re: directory layout changes
Post by: John_Betong on 1 Dec 2020, 05:24:59 pm
I prefer a common assets folder with css, js,  svg and imgs sub folders just below root and containing all public accessible files.

All system and application files above the root making it easier to update or revert back to previous  versions.


Root directory only contains an index.php file used to call applications above the root.



Title: Re: directory layout changes
Post by: benanamen on 1 Dec 2020, 06:03:37 pm
I prefer a common assets folder with css, js,  svg and imgs sub folders

Sure. Right now we have CSS files mixed with Php template files in a templates directory and JS in a scripts directory in the templates folder.
Title: Re: directory layout changes
Post by: John_Betong on 1 Dec 2020, 07:59:19 pm
Until I’m back on the desktop...

could someone confirm that Jason’s below the root directory structure prevents viewing files within the directory?

Normally I would view source then click on the link to the CSS file which would show the contents.

Edit:
Same for JavaScript and images. The reason why these files can be viewed by Joe Public for SEO purposes.

Edit - back on the desktop:
Most of the files could be viewed except for the favicon.ico
Quote

ERROR 404 - Not Found!
The following error occurred:The requested URL was not found on this server.
Please check the URL or contact the webmaster.


Title: Re: directory layout changes
Post by: xmohamadx on 2 Dec 2020, 12:29:40 am
Most of the files could be viewed except for the favicon.ico

There is no such file, there wasn't from the beginning, the name of the file just written.
Title: Re: directory layout changes
Post by: John_Betong on 2 Dec 2020, 01:52:38 am



@xmohamdx,


./deathshadow/default.ini.php:
   13  [link]
   14  favicon[rel]  = "shortcut icon"
   15: favicon[href] = favicon.ico


The missing favicon.ico is causing the ERROR 404 - Not Found!
Title: Re: directory layout changes
Post by: xmohamadx on 2 Dec 2020, 02:07:03 am

./deathshadow/default.ini.php:
   13  [link]
   14  favicon[rel]  = "shortcut icon"
   15: favicon[href] = favicon.ico


The missing favicon.ico is causing the ERROR 404 - Not Found!

Yes, as I said the name of the file (favicon.ico) is just written in the default.ini.php, but the file itself doesn't exist in the directory, I did add my "favicon.ico" to fix.
Title: Re: directory layout changes
Post by: Jason Knight on 2 Dec 2020, 02:18:29 am
Ah the petty stupid shit I assume people are smart enough to figure out. My bad.